Allow simult. use of partic incl and excl flags #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
akhanf,
Bradley-Karat,
mcespedes99 and
myousif9
The previous restriction was arbitrary. The use of both works according to the set operation: POPULATION ∩ INCLUDE - EXCLUDE This will allow better CLI composability Resolves khanlab#343
pvandyken
force-pushed
the
feat/filtering/simul-include-exclude
branch
from
2ebeb73 to
0b558e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 92.10% 92.08% -0.02%
==========================================
Files 41 41
Lines 1785 1782 -3
==========================================
- Hits 1644 1641 -3
Misses 141 141 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous restriction was arbitrary. The use of both works according to the set operation:
POPULATION ∩ INCLUDE - EXCLUDE
This will allow better CLI composability.
The tests for include and exclude-participant-label have been rolled into one test.
Resolves #343